-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: outdated CI actions #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fix: outdated CI actions #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikey-
commented
Jun 5, 2025
Update for https://github.com/mikey-/metrics/actions/runs/15459707849/attempts/1 Accepted in https://github.com/mikey-/metrics/pull/3#issuecomment-2942894076 Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
3bad16d
to
e3ee44d
Compare
a0e933c
to
df58752
Compare
Just getting in before this gets the stale label. As with #1715, I don't think it's appropriate to keep this PR open - as the PR itself will soon become outdated. I will now close this PR and just focus on trying to keep my fork up-to-date and working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of the workflows are using outdated versions of actions which in-turn rely on outdated versions of other actions. This is causing the build to fail.
At the moment, it seems to be failing on the on the
spelling
workflow, but I suspect that it would fail for the same reasons if the other workflows weren't skipped.So, I have updated the following actions to their latest major versions. The only exception is
check-spelling/check-spelling
, which I updated to a patch version as there is no major or minor version (it's currently0.0.20
, I updated it to0.0.25
).As a result of updating
action/labeler
, the config had to be updated. While I was doing that, I included a few labels for CI changes:This will be useful because lately there have been many changes to the CI, so they can be categorised now.
As I have modified many of the "repository level files", either:
To be honest, my preference is to remove the test, but I understand why it's there and this is not my repo, so I chose to add myself to the list. If this is an issue which blocks this MR from being merged, I'll gladly remove myself from the list - at least we can see that the linting is now passing.